[asterisk-dev] [Code Review] 3397: testsuite: directory fixes to prevent untracked files from being created in the svn directory

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3397/
-----------------------------------------------------------

(Updated June 6, 2014, 9:43 a.m.)


Review request for Asterisk Developers and wdoekes.


Changes
-------

Addressed Walter's comments.  Replace variables testdir and self.testdir with self.test_name.


Bugs: ASTERISK-23538
    https://issues.asterisk.org/jira/browse/ASTERISK-23538


Repository: testsuite


Description
-------

run-local: install asttest within astroot directory structure, fix the path statement (local install of asttest was never in $PATH before).
lib/python/asterisk.py: add get_path
chanspy_barge, chanspy_w_mixmonitor: use astspooldir/tmp to write the testaudio1
sip_tls_call & sip_tls_register: use key files from original location instead of copying them
fax/sip/local_channel_t38_queryoption, udptl, udptl_v6: store file from ReceiveFax in ${ASTDATADIR}

asterisk.get_path is designed to be used in place of manual path construction involving asterisk._base, and to encourage use of os.path.join style construction.

Though reviewboard isn't showing it, this patch adds 'astroot' to svn:ignore of the testsuite root.


Diffs (updated)
-----

  /asterisk/trunk/tests/udptl_v6/configs/ast2/extensions.conf 5094 
  /asterisk/trunk/tests/udptl/configs/ast2/extensions.conf 5094 
  /asterisk/trunk/tests/fax/sip/local_channel_t38_queryoption/configs/ast2/extensions.conf 5094 
  /asterisk/trunk/tests/channels/SIP/sip_tls_register/run-test 5094 
  /asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test 5094 
  /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/helper2 5094 
  /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/helper1 5094 
  /asterisk/trunk/tests/apps/chanspy/chanspy_w_mixmonitor/run-test 5094 
  /asterisk/trunk/tests/apps/chanspy/chanspy_barge/run-test 5094 
  /asterisk/trunk/run-local 5094 
  /asterisk/trunk/lib/python/asterisk/asterisk.py 5094 

Diff: https://reviewboard.asterisk.org/r/3397/diff/


Testing
-------

Verified all modified tests still using work with run-local, and no longer create any untracked files in svn.  I believe these changes to be correct for use without run-local, but can't test that.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140606/64b3d434/attachment.html>