[asterisk-dev] [Code Review] 3578: Update tests for channel snapshot reduction; add AMI channelvars/Status action test

opticron reviewboard at asterisk.org
Thu Jun 5 16:24:01 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3578/#review12064
-----------------------------------------------------------

Ship it!


Ship It!

- opticron


On June 1, 2014, 4:16 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3578/
> -----------------------------------------------------------
> 
> (Updated June 1, 2014, 4:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23811
>     https://issues.asterisk.org/jira/browse/ASTERISK-23811
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch updates tests in the Test Suite for r3568.
> 
> The only behaviour change that occurs as a result of r3568 are CDR results in parkcall_timeout comebacktoorigin tests. The CDRs that changed are those that occur when a channel is Parked. Previously, those records would contain the context/extension of the location of the dial back when the park times out; now, that information is only on the record that occurs when the dial is made to the parker. This is actually more in line with what should happen: it doesn't make much sense for information associated with a timeout callback to be on the parking record.
> 
> This patch also includes a test for AMI Stasus and the AMI channelvars setting. This action and that setting were affected by the patch. Both tests pass with the presence of the patch.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/manager/tests.yaml 5089 
>   /asterisk/trunk/tests/manager/status/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/status/status.py PRE-CREATION 
>   /asterisk/trunk/tests/manager/status/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/manager/manager_vars/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/manager_vars/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/manager/manager_vars/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/test-config.yaml 5089 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/test-config.yaml 5089 
> 
> Diff: https://reviewboard.asterisk.org/r/3578/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140605/604a863f/attachment.html>


More information about the asterisk-dev mailing list