[asterisk-dev] [Code Review] 3579: odbc: Fix for remove fixed size buffers fix (r414968).

[wdoekes]

> On June 2, 2014, 1:47 p.m., Tilghman Lesher wrote:
> > /branches/1.8/funcs/func_odbc.c, line 931
> > <https://reviewboard.asterisk.org/r/3579/diff/2/?file=59179#file59179line931>
> >
> >     Red blob, while you're in the neighborhood.

I'll remember to touch that when committing.


> On June 2, 2014, 1:47 p.m., Tilghman Lesher wrote:
> > /branches/1.8/funcs/func_odbc.c, lines 1401-1403
> > <https://reviewboard.asterisk.org/r/3579/diff/2/?file=59179#file59179line1401>
> >
> >     I assume you're going to fix this in trunk?

No, not right now.

Feel free to take it. (Note that I don't mind if that fix goes into 1.8.)


- wdoekes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3579/#review12025
-----------------------------------------------------------


On June 2, 2014, noon, wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3579/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, noon)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Mea culpa.
> 
> I okayed r3557, but it introduced a segfault.
> https://reviewboard.asterisk.org/r/3557/
> http://lists.digium.com/pipermail/asterisk-commits/2014-May/068614.html
> 
> sql_insert is optional. Previously, this was a static buffer, so it would never be NULL.
> Now it is dynamic and can be NULL, creating trouble.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/funcs/func_odbc.c 414989 
> 
> Diff: https://reviewboard.asterisk.org/r/3579/diff/
> 
> 
> Testing
> -------
> 
> After the patch, asterisk didn't crash on a write query anymore.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140602/77de31e2/attachment-0001.html>