[asterisk-dev] [Code Review] 3579: odbc: Fix for remove fixed size buffers fix (r414968).

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3579/
-----------------------------------------------------------

(Updated June 2, 2014, noon)


Review request for Asterisk Developers and Joshua Colp.


Changes
-------

Also fix missing strdup return value checks.

Also fix inconsistent use of linefeeds in function descriptions.

Also ensure that the empty SQL statement is consistently regarded as not-supplied.

Also pair sql-result-close statements in a more logical fashion.


Repository: Asterisk


Description
-------

Mea culpa.

I okayed r3557, but it introduced a segfault.
https://reviewboard.asterisk.org/r/3557/
http://lists.digium.com/pipermail/asterisk-commits/2014-May/068614.html

sql_insert is optional. Previously, this was a static buffer, so it would never be NULL.
Now it is dynamic and can be NULL, creating trouble.


Diffs (updated)
-----

  /branches/1.8/funcs/func_odbc.c 414989 

Diff: https://reviewboard.asterisk.org/r/3579/diff/


Testing
-------

After the patch, asterisk didn't crash on a write query anymore.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140602/0f918080/attachment.html>