[asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

[Michael K.]

> On July 30, 2014, 3:34 p.m., Mark Michelson wrote:
> > trunk/channels/chan_sip.c, lines 30492-30498
> > <https://reviewboard.asterisk.org/r/3867/diff/1/?file=65719#file65719line30492>
> >
> >     Use ast_rtp_dtls_cfg_copy() here. The current change has two problems:
> >     
> >     1) Many of the default DTLS settings are never copied onto the peer, so setting them doesn't do anything.
> >     
> >     2) Since you are doing a shallow copy of the default strings, there is potential to end up freeing the default values when you don't mean to.

As enums and ints by default have value, i loaded them to peer before loop(for) where we read the settings.
No strings here at all on purpose.
I did not want to copy the string value if not needed (peer has own or for example DTLS is not enabled at all)

I'll redo it and re-apply patch


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3867/#review12924
-----------------------------------------------------------


On July 30, 2014, 9:15 a.m., Michael K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3867/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 9:15 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24128
>     https://issues.asterisk.org/jira/browse/ASTERISK-24128
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Load default dtls settings from [general settings]
> If peer has dtls enabled but misses some of the settings and they are set in default settings it would load them from there.
> It would be logical as most of sip settings work like that and as well as there is no way to use template in realtime and it would lead to copy paste same settings for every peer.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 419804 
> 
> Diff: https://reviewboard.asterisk.org/r/3867/diff/
> 
> 
> Testing
> -------
> 
> Test on development server (ast 11.11.0)
> 
> 
> Thanks,
> 
> Michael K.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140731/2c1ac199/attachment-0001.html>