[asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

rnewton reviewboard at asterisk.org
Wed Jul 30 17:40:18 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3854/
-----------------------------------------------------------

(Updated July 30, 2014, 10:40 p.m.)


Review request for Asterisk Developers.


Changes
-------

Integrated Josh and Mark's comments.

Additionally, I modified the descriptions of the parameters for clarity. For example, for Setvar, the "Variable" parameter can really be set to a variable name, function or expression.

I didn't mention expressions in the descriptions to avoid being overly verbose and explicit.


Bugs: ASTERISK-21178
    https://issues.asterisk.org/jira/browse/ASTERISK-21178


Repository: Asterisk


Description
-------

The documentation wasn't clear that AMI Getvar and Setvar could accept function calls.

This is a slight modification to improve clarity.


Diffs (updated)
-----

  /branches/1.8/main/manager.c 419821 

Diff: https://reviewboard.asterisk.org/r/3854/diff/


Testing
-------

Once finalized I'll build in dev-mode with it to make sure I didn't screw up any tags.


Thanks,

rnewton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140730/04762fbf/attachment.html>


More information about the asterisk-dev mailing list