[asterisk-dev] [Code Review] 3874: Add tests for the DeviceStateList, PresenceStateList, and ExtensionStateList AMI actions

opticron reviewboard at asterisk.org
Wed Jul 30 14:47:54 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3874/
-----------------------------------------------------------

(Updated July 30, 2014, 2:47 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

This updates the patch according to the review items present on review 3843.


Repository: testsuite


Description
-------

This patch adds tests for the DeviceStateList, PresenceStateList, and ExtensionStateList AMI actions. Each test:

 * Sets two device/presence/device & presence state values (respectively for each of the previously listed actions)
 * Runs the appropriate list action
 * Verifies that the action has the expected response
 * Verifies that the intermediate expected events are received
 * Verifies that the list complete event is received

This review supersedes review 3843 and starts with its most recent patch.


Diffs (updated)
-----

  asterisk/trunk/tests/manager/tests.yaml 5305 
  asterisk/trunk/tests/manager/presence_state_list/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/manager/presence_state_list/ami_presence_state_list.py PRE-CREATION 
  asterisk/trunk/tests/manager/exten_state_list/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/manager/exten_state_list/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/manager/exten_state_list/ami_exten_state_list.py PRE-CREATION 
  asterisk/trunk/tests/manager/device_state_list/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/manager/device_state_list/ami_device_state_list.py PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3874/diff/


Testing
-------

Ensured the tests worked as expected.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140730/8f532ec4/attachment.html>


More information about the asterisk-dev mailing list