[asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3854/#review12902
-----------------------------------------------------------



/branches/1.8/main/manager.c
<https://reviewboard.asterisk.org/r/3854/#comment23275>

    This confuses me, even after reading a few times. Specifically what you've added: "directly or via function". Dialplan functions usually don't set variables.
    
    "Set a channel variable or execute a dialplan function." is clearer
    
    Same applies for the other modifications.
    
    Thoughts?


- Joshua Colp


On July 25, 2014, 2:20 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3854/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 2:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21178
>     https://issues.asterisk.org/jira/browse/ASTERISK-21178
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The documentation wasn't clear that AMI Getvar and Setvar could accept function calls.
> 
> This is a slight modification to improve clarity.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/manager.c 419562 
> 
> Diff: https://reviewboard.asterisk.org/r/3854/diff/
> 
> 
> Testing
> -------
> 
> Once finalized I'll build in dev-mode with it to make sure I didn't screw up any tags.
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140729/bfbf091b/attachment.html>