[asterisk-dev] [Code Review] 3843: Add tests for the DeviceStateList, PresenceStateList, and ExtensionStateList AMI actions

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3843/#review12899
-----------------------------------------------------------


The two findings below apply to all three tests.


/asterisk/trunk/tests/manager/device_state_list/ami_device_state_list.py
<https://reviewboard.asterisk.org/r/3843/#comment23273>

    ami.collectDeferred would be a more appropriate way to handle collecting the components of a list response.



/asterisk/trunk/tests/manager/device_state_list/ami_device_state_list.py
<https://reviewboard.asterisk.org/r/3843/#comment23272>

    Why not just use ami.setVar(None, device, state['state']?
    
    setVar's channel parameter is optional.


- opticron


On July 23, 2014, 3:09 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3843/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 3:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds tests for the DeviceStateList, PresenceStateList, and ExtensionStateList AMI actions. Each test:
> 
>  * Sets two device/presence/device & presence state values (respectively for each of the previously listed actions)
>  * Runs the appropriate list action
>  * Verifies that the action has the expected response
>  * Verifies that the intermediate expected events are received
>  * Verifies that the list complete event is received
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/manager/tests.yaml 5304 
>   /asterisk/trunk/tests/manager/presence_state_list/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/presence_state_list/ami_presence_state_list.py PRE-CREATION 
>   /asterisk/trunk/tests/manager/exten_state_list/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/exten_state_list/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/manager/exten_state_list/ami_exten_state_list.py PRE-CREATION 
>   /asterisk/trunk/tests/manager/device_state_list/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/manager/device_state_list/ami_device_state_list.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140729/a3809e00/attachment-0001.html>