[asterisk-dev] [Code Review] 3851: res_pjsip_pidf_body_generator / res_pjsip_xpidf_body_generator: Ensure entity is unquoted.

Matt Jordan reviewboard at asterisk.org
Mon Jul 28 20:41:23 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3851/#review12898
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 25, 2014, 8:19 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3851/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 8:19 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The local URI passed to body generators is currently quoted. Some generators (pidf and xpidf) place this into XML which produces invalid XML. This change ensures that the local URI is not quoted.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_xpidf_body_generator.c 419341 
>   /branches/12/res/res_pjsip_pidf_body_generator.c 419341 
> 
> Diff: https://reviewboard.asterisk.org/r/3851/diff/
> 
> 
> Testing
> -------
> 
> Had a NOTIFY sent without quotes.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140729/3228c1bf/attachment.html>


More information about the asterisk-dev mailing list