[asterisk-dev] [Code Review] 3865: Stasis: Handle incoming masquerades

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3865/#review12884
-----------------------------------------------------------



team/group/ari-greedy-atxfer/res/res_stasis.c
<https://reviewboard.asterisk.org/r/3865/#comment23251>

    The ao2_unlink likely will have a problem finding the object if the key has changed before it was removed.  You likely will have to do an ao2_callback of the container to actually find and remove it.
    
    Could use the ao2_callback that finds the control to unlink it as well.
    
    During the masquerade, the app_controls container is broken while the object key indicates it should be in a different location of the container.  An ao2_container integrity check will fail at this time if the checks are enabled.



team/group/ari-greedy-atxfer/res/stasis/app.c
<https://reviewboard.asterisk.org/r/3865/#comment23250>

    Is OBJ_NOLOCK needed here?  It wasn't used on the ao2_find above.


- rmudgett


On July 28, 2014, 9:56 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3865/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 9:56 a.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
> 
> 
> Bugs: ASTERISK-23941
>     https://issues.asterisk.org/jira/browse/ASTERISK-23941
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds handling for a channel being pushed into Stasis() via masquerade. It notifies the Stasis() application using the previously established StasisStart with the "replace_channel" key populated with a channel snapshot of the channel that is being replaced. It also sets up the new channel topic forwards required to get information from the new channel and tears down the old channel topic forwards.
> 
> This patch also introduces the concept of chan_breakdown datastore callbacks which are called for the channel being masqueraded into during a masquerade.
> 
> 
> Diffs
> -----
> 
>   team/group/ari-greedy-atxfer/res/stasis/app.c 419681 
>   team/group/ari-greedy-atxfer/res/stasis/app.h 419681 
>   team/group/ari-greedy-atxfer/res/res_stasis.c 419681 
>   team/group/ari-greedy-atxfer/main/channel.c 419681 
>   team/group/ari-greedy-atxfer/include/asterisk/datastore.h 419681 
> 
> Diff: https://reviewboard.asterisk.org/r/3865/diff/
> 
> 
> Testing
> -------
> 
> Verified that the correct messages were being received by the Stasis() application monitoring the channel.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140728/59370c9d/attachment.html>