[asterisk-dev] [Code Review] 3861: datastores: Audit v12 ast_channel_datastore_remove usage.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3861/#review12883
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 25, 2014, 9:03 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3861/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 9:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Audit of v12 usage of ast_channel_datastore_remove() for datastore memory leaks.
> 
> * Fixed leaks in abstract_jb.
> 
> * Fixed leak in ast_channel_unsuppress().  Used by ARI mute control and res_mutestream.
> 
> * Fixed ref leak in ast_channel_suppress().  Used by ARI mute control and res_mutestream.
> 
> This is the additions for v12 over the v1.8 audit at https://reviewboard.asterisk.org/r/3859/ and v11 audit at https://reviewboard.asterisk.org/r/3860/
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/channel.c 419680 
>   /branches/12/main/abstract_jb.c 419680 
> 
> Diff: https://reviewboard.asterisk.org/r/3861/diff/
> 
> 
> Testing
> -------
> 
> Code inspection and compiler.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140728/e578d177/attachment.html>