[asterisk-dev] [Code Review] 3859: datastores: Audit v1.8 ast_channel_datastore_remove usage.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3859/#review12881
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 25, 2014, 9:04 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3859/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 9:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Audit of v1.8 usage of ast_channel_datastore_remove() for datastore memory leaks.
> 
> * Fixed leaks in app_speech_utils and func_frame_trace.
> 
> * Fixed app_speech_utils not locking the channel when accessing the channel datastore list.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/funcs/func_frame_trace.c 419627 
>   /branches/1.8/apps/app_speech_utils.c 419627 
>   /branches/1.8/apps/app_queue.c 419627 
> 
> Diff: https://reviewboard.asterisk.org/r/3859/diff/
> 
> 
> Testing
> -------
> 
> Code inspection and compiler.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140728/0d0fdbbc/attachment.html>