[asterisk-dev] [Code Review] 3862: testsuite: run-local creates broken symlinks for tests

Corey Farrell reviewboard at asterisk.org
Fri Jul 25 21:30:21 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3862/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-24126
    https://issues.asterisk.org/jira/browse/ASTERISK-24126


Repository: testsuite


Description
-------

When using run-local, files are created in /tmp/ast_test_XXXXXX symbolic links created by mktemp.  Each test is run in an folder named by the md5 of the test name.  Unfortunately the absolute path is broken as soon as run-local exits.  This additionally causes the testsuite to fail to find log files on all runs past the first.

I believe the solution is to symbolic link the test run dir using relative paths.


Diffs
-----

  /asterisk/trunk/lib/python/asterisk/test_case.py 5316 

Diff: https://reviewboard.asterisk.org/r/3862/diff/


Testing
-------

./run-local run -t tests/channels/SIP/path;
./run-local run -t tests/predial
Both tests resulted in symbolic links from astroot/tmp/<testname> to the md5 folder.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140726/85f2c353/attachment.html>


More information about the asterisk-dev mailing list