[asterisk-dev] [svn-commits] mjordan: trunk r419358 - in /trunk: channels/chan_pjsip.c main/devicestate.c

[Olle E. Johansson]

On 24 Jul 2014, at 17:21, SVN commits to the Digium repositories <svn-commits at lists.digium.com> wrote:

> device state: Update the core to report ONHOLD if a channel is on hold
> 
Aren't you mixing channel states with device and extension states here?

A phone (a device or line) can't be on hold - a call can be. It's an attribute to a call in up state.

I agree it was a hack in the channel drivers that belonged to the core, but well, it happened.

We just need to make sure that all consumers of device state see this as equal to INUSE.
And that all aggregation of states handle it well.

But maybe this confusion is all around and it's the way it' gotta be. 

Scary. 

/O :-)