[asterisk-dev] [Code Review] 3840: bridge: Move "bridge destroy" CLI command to devmode and add "all" to "bridge kick" CLI command

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3840/#review12864
-----------------------------------------------------------



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/3840/#comment23232>

    This RAII_VAR can easily be eliminated as well.  There are only two exit points that need to cleanup.



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/3840/#comment23233>

    ...name all..
    ...name then all...



/branches/12/main/bridge.c
<https://reviewboard.asterisk.org/r/3840/#comment23234>

    Maybe add a:
    Kicking everything from bridge '%s'.
    message.


- rmudgett


On July 23, 2014, 4:53 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3840/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 4:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The "bridge destroy" CLI command is dangerous for mere mortals. It can send bridges into an unusable state when the owner of them did not expect it to happen. Its very existence instills paranoia upon the users of bridges since they must be aware that the very bridge they created may need to be recreated at any time. I think this is unreasonable so I've moved it to be a devmode only CLI command since it can potentially be useful when working with things. In its normal place I have added "all" as a valid option to the "bridge kick" CLI command. When invoked all channels will be kicked out of the bridge instead of one specific one.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/bridge.c 419126 
> 
> Diff: https://reviewboard.asterisk.org/r/3840/diff/
> 
> 
> Testing
> -------
> 
> Executed "bridge kick all" and confirmed all channels were kicked out.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140724/cd188dc6/attachment.html>