[asterisk-dev] [Code Review] 3834: chan_sip: sip_subscribe_mwi_destroy should not call sip_destroy

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3834/
-----------------------------------------------------------

(Updated July 24, 2014, 12:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 419440


Bugs: ASTERISK-24087
    https://issues.asterisk.org/jira/browse/ASTERISK-24087


Repository: Asterisk


Description
-------

sip_subscribe_mwi_destroy calls sip_destroy on the reference counted mwi->call.  This results in the fields of mwi->call being freed, but mwi->call itself it leaked.  Also if other code is still using mwi->call it can cause problems.  This change uses dialog_unref instead, to balance the ref provided by sip_alloc().


Diffs
-----

  /branches/1.8/channels/chan_sip.c 418992 

Diff: https://reviewboard.asterisk.org/r/3834/diff/


Testing
-------

None


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140724/db228c17/attachment-0001.html>