[asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3842/#review12850
-----------------------------------------------------------



/asterisk/trunk/tests/rest_api/bridges/playback/forward/test-config.yaml
<https://reviewboard.asterisk.org/r/3842/#comment23194>

    Two points here:
    
    (1) You should be triggering the deletion of the channel and the bridge after the playback has completed. You can trigger that on a PlaybackFinished event. You shouldn't need a delay for those at that point (or at least a minimal one should suffice)
    
    (2) Your delay to delete the playback can probably be a bit shorter.
    
    This finding applies to the reverse test as well.



/asterisk/trunk/tests/rest_api/bridges/playback/forward/test-config.yaml
<https://reviewboard.asterisk.org/r/3842/#comment23195>

    Min version here should be 12.0.0.
    
    This finding applies to all tests here.



/asterisk/trunk/tests/rest_api/bridges/playback/forward/test-config.yaml
<https://reviewboard.asterisk.org/r/3842/#comment23196>

    Add a dependency on:
    
    res_ari_bridges
    res_ari_playback
    
    This finding applies to all bridge tests. The res_ari_playbacks module should be a dependency for all tests on this review.



/asterisk/trunk/tests/rest_api/channels/playback/forward/test-config.yaml
<https://reviewboard.asterisk.org/r/3842/#comment23197>

    The same finding about triggering deletion of the channel on playback finished applies here.


- Matt Jordan


On July 23, 2014, 1:23 p.m., Christopher Wolfe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3842/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 1:23 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: SWP-7157
>     https://issues.asterisk.org/jira/browse/SWP-7157
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test 1: Puts a local channel half into Stasis, and then plays back a sound on it (tt-monkeys).  Upon starting the sound, the playback gets reversed using /control?operation=reverse and a TestEvent gets released that signifies a reversal has occurred.
> 
> Test 2: Same thing as Test 1 except that you are using the /control?operation=forward ARI command and looking for a FastForward TestEvent.
> 
> Test 3: Same thing as Test 1 except that a channel gets put into a bridge, and the bridge instead is the one that starts the playback.
> 
> Test 4: Same thing as Test 3 except that you are testing the /control?operation=forward command on the bridge.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/channels/playback/tests.yaml 5249 
>   /asterisk/trunk/tests/rest_api/channels/playback/reverse/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/playback/reverse/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/playback/forward/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/playback/forward/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/playback/tests.yaml 5249 
>   /asterisk/trunk/tests/rest_api/bridges/playback/reverse/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/playback/reverse/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/playback/forward/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/playback/forward/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3842/diff/
> 
> 
> Testing
> -------
> 
> Made sure that expected values were received.  These tests were pretty straightforward otherwise.
> 
> 
> Thanks,
> 
> Christopher Wolfe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140724/5c6e420f/attachment-0001.html>