[asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint
Joshua Colp
reviewboard at asterisk.org
Thu Jul 24 07:59:24 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3817/#review12844
-----------------------------------------------------------
/trunk/res/res_pjsip_notify.c
<https://reviewboard.asterisk.org/r/3817/#comment23185>
Document in here that if an arbitrary URI is used the default outbound endpoint will be used, and that it is required.
/trunk/res/res_pjsip_notify.c
<https://reviewboard.asterisk.org/r/3817/#comment23186>
Rephrase this error. "You must use one or the other."
- Joshua Colp
On July 21, 2014, 5:23 p.m., Jonathan Rose wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3817/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 5:23 p.m.)
>
>
> Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Example:
>
> Action: PJSIPNotify
> URI: sip:10.10.10.10
>
> pjsip send notify uri <type> uri <uri> [uri...]
>
>
> Adds the ability to use URIs with the PJSIP notify commands instead of endpoints. These mostly work the same as the endpoint notifications.
>
>
> Diffs
> -----
>
> /trunk/res/res_pjsip_notify.c 419109
>
> Diff: https://reviewboard.asterisk.org/r/3817/diff/
>
>
> Testing
> -------
>
> Used existing endpoint notification and compared it to similar notifies done against URIs. The outgoing messages looked the same as far as the details I was concerned with went.
>
>
> Thanks,
>
> Jonathan Rose
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140724/e2bd7371/attachment-0001.html>
More information about the asterisk-dev
mailing list