[asterisk-dev] [Code Review] 3799: manager: Add ExtensionStateList, PresenceStateList, and DeviceStateList commands

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3799/
-----------------------------------------------------------

(Updated July 23, 2014, 3:16 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Kinsey's findings.


Repository: Asterisk


Description
-------

This patch adds three new AMI commands:
 * ExtensionStateList (pbx.c) - list all known extension state hints and their current statuses. Events emitted by the list action are equivalent to the ExtensionStatus events.
 * PresenceStateList (res_manager_presencestate) - list all known presence state values. Events emitted are generated by the stasis message type, and hence are PresenceStateChange events.
 * DeviceStateList (res_manager_devicestate) - list all known device state values. Events emitted are generated by the stasis message type, and hence are DeviceStateChange events.


Diffs (updated)
-----

  /trunk/res/res_manager_presencestate.c 419341 
  /trunk/res/res_manager_devicestate.c 419341 
  /trunk/main/pbx.c 419341 
  /trunk/main/manager.c 419341 

Diff: https://reviewboard.asterisk.org/r/3799/diff/


Testing
-------

Currently, only manual verification:

 * Made two hints, one with presence.
 * Ran all three commands and checked the output
 * Used a Custom device state and a CustomPresence provider and changed their statuses using a Local channel and the DEVICE_STATE/PRESENCE_STATE functions
 * Ran all three commands again and got back the expected updated values

Update:

Tests are now available on review 3843: https://reviewboard.asterisk.org/r/3843/


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140723/36ab969b/attachment.html>