[asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

[opticron]

> On July 22, 2014, 5:29 p.m., Corey Farrell wrote:
> > trunk/main/xmldoc.c, lines 2182-2188
> > <https://reviewboard.asterisk.org/r/3812/diff/3/?file=64854#file64854line2182>
> >
> >     This seems to break the guideline of not doing adhoc list code.  If this can be fixed without much trouble please do so.  I suspect this is due to the way that ast_xml_doc_item is written in which case you can ignore this comment.

This type of code is pretty prevalent in config_options.c. I'll see what I can do after I address the other issues and update the patch.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3812/#review12768
-----------------------------------------------------------


On July 18, 2014, 2:57 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3812/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 2:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Allow for responses to AMI actions/commands to be documented properly in XML and displayed via the CLI. Response events are documented exactly as standard AMI events are documented.
> 
> 
> Diffs
> -----
> 
>   trunk/main/xmldoc.c 418964 
>   trunk/main/manager_bridges.c 418964 
>   trunk/main/manager.c 418964 
>   trunk/include/asterisk/xmldoc.h 418964 
>   trunk/include/asterisk/manager.h 418964 
>   trunk/doc/appdocsxml.dtd 418964 
> 
> Diff: https://reviewboard.asterisk.org/r/3812/diff/
> 
> 
> Testing
> -------
> 
> The BridgeInfo AMI command was documented and tested as an example.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140722/38ebbce6/attachment-0001.html>