[asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

[Corey Farrell]

> On July 22, 2014, 12:24 p.m., rmudgett wrote:
> > /trunk/channels/chan_sip.c, lines 15568-15571
> > <https://reviewboard.asterisk.org/r/3759/diff/4/?file=64989#file64989line15568>
> >
> >     Something seems off here.  The ao2_t_ref() calls return ints and are parameters to AST_SCHED_REPLACE_UNREF().  Didn't registry_unref() return a pointer?
> >
> 
> opticron wrote:
>     The scheduler macros don't actually use return values for any of these. They exist only to ref or unref the given variable if the scheduler macro deems it necessary.

I know it looks weird, but opticron is right.  These "parameters" are actually code injection, not values.


> On July 22, 2014, 12:24 p.m., rmudgett wrote:
> > /trunk/channels/chan_sip.c, line 8830
> > <https://reviewboard.asterisk.org/r/3759/diff/4/?file=64989#file64989line8830>
> >
> >     Where are file, line, and func coming from?  They don't seem to be passed in to sip_alloc.

This was never meant to be submitted, was part of some debug code I was using in an attempt to find a memory leak (not caused by this change).


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12807
-----------------------------------------------------------


On July 22, 2014, 6:01 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3759/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 6:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24067
>     https://issues.asterisk.org/jira/browse/ASTERISK-24067
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Upgrade all ASTOBJ objects in chan_sip to ao2.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/include/sip.h 419127 
>   /trunk/channels/chan_sip.c 419127 
> 
> Diff: https://reviewboard.asterisk.org/r/3759/diff/
> 
> 
> Testing
> -------
> 
> Full testsuite run.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140722/7cf108b8/attachment.html>