[asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

[Samuel Galarneau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3839/#review12819
-----------------------------------------------------------



/asterisk/trunk/tests/rest_api/recording/duration/test-config.yaml
<https://reviewboard.asterisk.org/r/3839/#comment23150>

    energy_duration was renamed to talking_duration in the latest patch to add duration information to RecordingFinished events. This should be renamed.



/asterisk/trunk/tests/rest_api/recording/duration/test-config.yaml
<https://reviewboard.asterisk.org/r/3839/#comment23151>

    energy_duration was renamed to talking_duration in the latest patch to add duration information to RecordingFinished events. This should be renamed.


- Samuel Galarneau


On July 22, 2014, 7:40 p.m., Christopher Wolfe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3839/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 7:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24037
>     https://issues.asterisk.org/jira/browse/ASTERISK-24037
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test checks whether the duration and energy_duration of a recording created in ARI are both valid.  One local channel half in ARI plays back 2 seconds worth of sound (tt-somethingwrong), plays two seconds worth of silence (silence/2), and then plays the first sound again.  The other local channel half records these sounds as they are played.  The total duration of the recorded sound file should be 6 seconds, while the energy_duration should be 4 seconds.  When this gets verified, the SoundChecker pluggable module gets called and the sound file's size (should be around 96,000 bytes) gets verified, as well as the sound file's energy levels using BackgroundDetect.  Since the SoundChecker pluggable module hasn't received a Ship It! yet, a dependency has been added accordingly.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/recording/tests.yaml 5249 
>   /asterisk/trunk/tests/rest_api/recording/duration/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/recording/duration/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3839/diff/
> 
> 
> Testing
> -------
> 
> Checked whether the recording object did return the correct values in the log files.  One bottleneck to finishing this test was the fact that you had to add maxSilenceSeconds in the recording request in order to make energy_detection work AT ALL.  Other than that, this test was pretty straightforward and easy to write.
> 
> 
> Thanks,
> 
> Christopher Wolfe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140722/c2729e9c/attachment.html>