[asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

[Tyler Austin Cambron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3795/
-----------------------------------------------------------

(Updated July 22, 2014, 3:01 p.m.)


Review request for Asterisk Developers.


Changes
-------

Corrected test to use the MixMonitor AMI command rather than call MixMonitor through the dialplan by adding a small bit of python code. The test-config.yaml has been updated to work with updates to the SoundChecker pluggable module. Also updated the size to check for in the test-config to be slightly more accurate.


Bugs: Asterisk-24028
    https://issues.asterisk.org/jira/browse/Asterisk-24028


Repository: testsuite


Description
-------

This is a test that verifies that the recording feature of MixMonitor is functioning properly. The test uses the SoundChecker pluggable module, which is currently still up for review, so the test could change depending on changes with the pluggable module. Assuming the pluggable module is working correctly, this test uses the pluggable module to verify that audio has been recorded from a local channel call and that the recording has correctly created a sound file that contains the full recording. The pluggable module will appear in the diff, specifically to show how the test uses the pluggable module. Please do not review the module on this thread, as it is being reviewed in another thread posted by cwolfe.


Diffs (updated)
-----

  /asterisk/trunk/tests/apps/tests.yaml 5297 
  /asterisk/trunk/tests/apps/mixmonitor_record/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/start_mix.py PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_record/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 5297 

Diff: https://reviewboard.asterisk.org/r/3795/diff/


Testing
-------

The test begins by executing dialplan, where MixMonitor is started and a playback of tt-monkeys begins. MixMonitor records this audio and stores it into a file called theRecording.wav. When the recording is finished, the dialplan executes a hangup, which triggers (through the yaml file) a size check and energy check on the newly created file, which is done using the SoundChecker pluggable module. The test logs confirm that a call is made, the audio starts and is recorded, the file is saved, and then the pluggable module verifies that the file has the correct size and energy, showing that there is actual audio in the file. I also went and found the file manually, and the recording fully played back tt-monkeys.


Thanks,

Tyler Austin Cambron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140722/6b7f5dfa/attachment-0001.html>