[asterisk-dev] [Code Review] 3813: codec_speex: Fix trashing normal static frame for AST_FRAME_CNG.
rmudgett
reviewboard at asterisk.org
Mon Jul 21 17:35:44 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3813/#review12800
-----------------------------------------------------------
Ping for attention.
- rmudgett
On July 16, 2014, 4:37 p.m., rmudgett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3813/
> -----------------------------------------------------------
>
> (Updated July 16, 2014, 4:37 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Made use a local static frame to generate the AST_FRAME_CNG frame when silence starts.
>
> I don't think the handling of the AST_FRAME_CNG has ever really worked because there doesn't seem to be any consumers of it.
>
>
> Diffs
> -----
>
> /team/group/media_formats-reviewed-trunk/codecs/codec_speex.c 418785
>
> Diff: https://reviewboard.asterisk.org/r/3813/diff/
>
>
> Testing
> -------
>
> It compiles. I don't have anything that will consume/produce speex.
>
>
> Thanks,
>
> rmudgett
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140721/7f4d1f30/attachment.html>
More information about the asterisk-dev
mailing list