[asterisk-dev] [Code Review] 3729: Stasis: Allow prestart actions to be queued

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3729/#review12795
-----------------------------------------------------------



branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/3729/#comment23114>

    There's no real need for count when you have ao2_container_count() available to you. You can cal it prior to iterating over the items since you're removing the commands from the queue as they are executed.


- Mark Michelson


On July 18, 2014, 5:48 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3729/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 5:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23941
>     https://issues.asterisk.org/jira/browse/ASTERISK-23941
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This allows commands to be queued in a channel datastore to be executed upon a channel entering Stasis(). This functionality is only available from components of res_stasis.so. This functionality is required to get a redirected channel back into the bridge for which it was destined due to the attended transfer.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/stasis/control.c 418910 
>   branches/12/res/stasis/control.h 418910 
>   branches/12/res/stasis/command.c 418910 
>   branches/12/res/stasis/command.h 418910 
>   branches/12/res/res_stasis.c 418910 
> 
> Diff: https://reviewboard.asterisk.org/r/3729/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of the complete solution to ASTERISK-23941.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140721/2af6da5c/attachment.html>