[asterisk-dev] [Code Review] 3810: res_hep_rtcp: Add module that sends RTCP information to a Homer Server

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3810/#review12790
-----------------------------------------------------------



/branches/12/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/3810/#comment23108>

    ast_sockaddr_stringify uses a thread-local buffer to store the stringified address. If you call it twice like this, the second call is going to overwrite the result of the first. The result is that both strings in this json object are likely to be the same.
    
    Typically, the way to work around this is to use ast_strdupa() on the result of ast_sockaddr_stringify() so that the local frame has a copy of the result of stringification.



/branches/12/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/3810/#comment23109>

    Same warning for ast_sockaddr_stringify() as before.


- Mark Michelson


On July 16, 2014, 10:37 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3810/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 10:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds a new module to Asterisk, res_hep_rtcp. The module subscribes to Stasis and receives RTCP information back from the message bus, which it encodes into HEPv3 packets and sends to the res_hep module for transmission.
> 
> Using this, someone with a Homer server can get live call quality monitoring for all channels in their Asterisk 12+ systems.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_rtp_asterisk.c 418783 
>   /branches/12/res/res_hep_rtcp.c PRE-CREATION 
>   /branches/12/CHANGES 418783 
> 
> Diff: https://reviewboard.asterisk.org/r/3810/diff/
> 
> 
> Testing
> -------
> 
> Some manual testing has be done, and automated tests have started being written in the Asterisk Test Suite. Note that they need to be completed before this is submitted.
> 
> As a side note, Alexander actually demo'd this at Kamailio World - you can see it on the 'dangerous demos' here - http://www.youtube.com/watch?v=ykBdOTCCSHs
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140721/38077cab/attachment.html>