[asterisk-dev] [Code Review] 3799: manager: Add ExtensionStateList, PresenceStateList, and DeviceStateList commands

[Mark Michelson]

> On July 18, 2014, 5:18 p.m., opticron wrote:
> >

I gave this review a look and only found the same findings as opticron.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3799/#review12755
-----------------------------------------------------------


On July 15, 2014, 8:55 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3799/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 8:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds three new AMI commands:
>  * ExtensionStateList (pbx.c) - list all known extension state hints and their current statuses. Events emitted by the list action are equivalent to the ExtensionStatus events.
>  * PresenceStateList (res_manager_presencestate) - list all known presence state values. Events emitted are generated by the stasis message type, and hence are PresenceStateChange events.
>  * DeviceStateList (res_manager_devicestate) - list all known device state values. Events emitted are generated by the stasis message type, and hence are DeviceStateChange events.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_manager_presencestate.c 418612 
>   /trunk/res/res_manager_devicestate.c 418612 
>   /trunk/main/pbx.c 418612 
>   /trunk/main/manager.c 418612 
> 
> Diff: https://reviewboard.asterisk.org/r/3799/diff/
> 
> 
> Testing
> -------
> 
> Currently, only manual verification:
> 
>  * Made two hints, one with presence.
>  * Ran all three commands and checked the output
>  * Used a Custom device state and a CustomPresence provider and changed their statuses using a Local channel and the DEVICE_STATE/PRESENCE_STATE functions
>  * Ran all three commands again and got back the expected updated values
> 
> Note that before this is committed, it must have tests covering the new AMI actions. This review will be updated when that test review is put up.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140721/f4016d56/attachment.html>