[asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12784
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3759/#comment23106>

    Heh, it's a bit late for this now, but it would have probably saved you a bunch of searching and replacing to just change the definition of registry_unref() and registry_addref() to use ao2 in their implementations.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3759/#comment23100>

    I agree with this comment. Since mwi->call was created via sip_alloc(), destruction of it should be accomplished with dialog_unref()



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3759/#comment23103>

    You sometimes search for sip_registrys using OBJ_KEY, but your hash and cmp callbacks do not account for a search key being passed to the callback instead of a sip_registry.
    
    Use the templates on this wiki page https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=25919686 to define your hash and comparison callbacks and you should be good to go.


- Mark Michelson


On July 21, 2014, 8:54 a.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3759/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 8:54 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24067
>     https://issues.asterisk.org/jira/browse/ASTERISK-24067
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Upgrade all ASTOBJ objects in chan_sip to ao2.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/include/sip.h 419043 
>   /trunk/channels/chan_sip.c 419043 
> 
> Diff: https://reviewboard.asterisk.org/r/3759/diff/
> 
> 
> Testing
> -------
> 
> Full testsuite run.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140721/d657d747/attachment-0001.html>