[asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

Matt Jordan reviewboard at asterisk.org
Mon Jul 21 11:52:14 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/#review12785
-----------------------------------------------------------



trunk/main/stasis.c
<https://reviewboard.asterisk.org/r/3823/#comment23101>

    Yay, I get to be that guy again :-(
    
    I should have noted this in the last review, but technically, the message types should be an enum for this configOption.
    
    As an example on structuring this, take a look at the DTMF menu options in confbridge.


- Matt Jordan


On July 18, 2014, 12:22 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3823/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 12:22 p.m.)
> 
> 
> Review request for Asterisk Developers and Corey Farrell.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This introduces stasis.conf and a mechanism to prevent certain message types from being published.
> 
> 
> Diffs
> -----
> 
>   trunk/tests/test_stasis_channels.c 418910 
>   trunk/tests/test_stasis.c 418910 
>   trunk/main/stasis_message.c 418910 
>   trunk/main/stasis_cache.c 418910 
>   trunk/main/stasis.c 418910 
>   trunk/include/asterisk/stasis.h 418910 
>   trunk/configs/samples/stasis.conf.sample PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3823/diff/
> 
> 
> Testing
> -------
> 
> Tested by causing the stasis unittests to fail with the following stasis.conf configuration:
> [declined_message_types]
> decline=TestMessage
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140721/939e9382/attachment.html>


More information about the asterisk-dev mailing list