[asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/
-----------------------------------------------------------

(Updated July 21, 2014, 3:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 419060


Bugs: ASTERISK-24066
    https://issues.asterisk.org/jira/browse/ASTERISK-24066


Repository: Asterisk


Description
-------

This code converts res_smdi to use astobj2.

* Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, ast_smdi_mwi_message destructor.

The putback methods were unused and difficult to reimplement using ao2_containers.

Includes for astobj.h are removed everywhere it's possible.  The only remaining users are netsock.c (deprecated) and chan_sip (to be updated in a separate review).


Diffs
-----

  /trunk/res/res_smdi.c 418788 
  /trunk/include/asterisk/smdi.h 418788 
  /trunk/channels/sig_analog.c 418788 
  /trunk/channels/chan_motif.c 418788 
  /trunk/channels/chan_dahdi.c 418788 
  /trunk/apps/app_voicemail.c 418788 

Diff: https://reviewboard.asterisk.org/r/3758/diff/


Testing
-------

Compile only (I do not have SMDI hardware).


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140721/77411407/attachment.html>