[asterisk-dev] [Code Review] 3820: MixMonitor: Add Options To Play Beep At Start Or End

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3820/#review12766
-----------------------------------------------------------

Ship it!



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/3820/#comment23079>

    I don't really feel like these log messages are especially helpful. Most of the time we call this function, we just ignore the return value.


Everything here seems good to go.  Minor issue with what may be excessive logging.

- Jonathan Rose


On July 16, 2014, 7:48 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3820/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 7:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24051
>     https://issues.asterisk.org/jira/browse/ASTERISK-24051
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While the new periodic beep feature is great for inserting beeps into a call being recorded, sometimes a user needs some sort of feedback (without the need to have periodic beeps during the recording) to let them know that MixMonitor started recording or ended the recording.
> 
> The use case where this is being used is when using Dynamic Features and starting/ending MixMonitor.
> 
> This patch adds an option to play a beep when MixMonitor starts and an option to play a beep when MixMonitor ends.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_mixmonitor.c 418785 
> 
> Diff: https://reviewboard.asterisk.org/r/3820/diff/
> 
> 
> Testing
> -------
> 
> This patch has been in use on an Asterisk 11 box for quite some time.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140718/825d72d3/attachment.html>