[asterisk-dev] [Code Review] 3829: Voicemail send email to multiple email addresses

Scott Griepentrog reviewboard at asterisk.org
Fri Jul 18 12:31:49 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3829/#review12758
-----------------------------------------------------------



/branches/12/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/3829/#comment23075>

    You need to add an empty string check here to prevent adding empty <>'s when an extra space is in the vmu->email string.


- Scott Griepentrog


On July 18, 2014, 11:55 a.m., Jacob Barber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3829/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 11:55 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24045
>     https://issues.asterisk.org/jira/browse/ASTERISK-24045
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently voicemail to email only works with a single email. This patch allows a user to use a space separated list of emails (up to 512 characters long), where the user would like for the emails to be sent. This is useful for people who don't want to go through setting up mailing groups, or for people who host provide VoIP services with asterisk as a backend, where their customers don't know how to set up mailing groups.
> 
> 
> Diffs
> -----
> 
>   /branches/12/apps/app_voicemail.c 418713 
> 
> Diff: https://reviewboard.asterisk.org/r/3829/diff/
> 
> 
> Testing
> -------
> 
> Tested calling and sending voicemails using the mysql realtime database and using the standard voicemail.conf implementation.
> 
> 
> Thanks,
> 
> Jacob Barber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140718/0f4cb23e/attachment.html>


More information about the asterisk-dev mailing list