[asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/#review12756
-----------------------------------------------------------



trunk/main/stasis.c
<https://reviewboard.asterisk.org/r/3823/#comment23071>

    This NOTICE is vague as to why it is declined.  It looks more like a resource allocation error rather than something the user possibly configured wrong.  How about:
    "Configured to decline creating Stasis message type %s\n"


- rmudgett


On July 18, 2014, 9:54 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3823/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 9:54 a.m.)
> 
> 
> Review request for Asterisk Developers and Corey Farrell.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This introduces stasis.conf and a mechanism to prevent certain message types from being published.
> 
> 
> Diffs
> -----
> 
>   trunk/tests/test_stasis_channels.c 418910 
>   trunk/tests/test_stasis.c 418910 
>   trunk/main/stasis_message.c 418910 
>   trunk/main/stasis_cache.c 418910 
>   trunk/main/stasis.c 418910 
>   trunk/include/asterisk/stasis.h 418910 
>   trunk/configs/samples/stasis.conf.sample PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3823/diff/
> 
> 
> Testing
> -------
> 
> Tested by causing the stasis unittests to fail with the following stasis.conf configuration:
> [declined_message_types]
> decline=TestMessage
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140718/32cf44f3/attachment-0001.html>