[asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3759/#review12742
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3759/#comment23056>

    This would be cleaner using ao2_t_bump.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3759/#comment23067>

    It really does seem wrong...but it's not.
    
    The DNS manager doesn't hold a reference to sip_subscription_mwi struct in the traditional sense, but it does hold a pointer into that struct so references must be managed around it (unfortunately).
    
    A possible improvement to the API could be to force objects containing that poniter to be AO2-allocated and hand that off to the DNS manager, but that opens the can of worms that is circular references (which is essentially what this is anyway, just horribly managed circular references).
    
    Go ahead and remove this line.



/trunk/channels/sip/include/sip.h
<https://reviewboard.asterisk.org/r/3759/#comment23057>

    This should be a string field as well.


- opticron


On July 12, 2014, 11:48 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3759/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 11:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Upgrade all ASTOBJ objects in chan_sip to ao2.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/include/sip.h 418438 
>   /trunk/channels/chan_sip.c 418438 
> 
> Diff: https://reviewboard.asterisk.org/r/3759/diff/
> 
> 
> Testing
> -------
> 
> Full testsuite run.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140718/085167fe/attachment.html>