[asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3765/
-----------------------------------------------------------

(Updated July 18, 2014, 9:58 a.m.)


Review request for Asterisk Developers.


Changes
-------

updated per comments to remove ao2_bt in favor of ast_log_backtrace and eliminate duplicate instances of backtracing (i.e. prior to assert).


Repository: Asterisk


Description
-------

On an invalid refcount, rather than just log the message and continue executing normally, provide a backtrace and an assert to stop on DO_CRASH.  This can help to catch the first case of an invalid refcount rather than being distracted from the problem with a flurry additional logs from other threads encountering already mangled data.


Diffs (updated)
-----

  /trunk/main/utils.c 418910 
  /trunk/main/logger.c 418910 
  /trunk/main/astobj2.c 418910 
  /trunk/include/asterisk/astobj2.h 418910 

Diff: https://reviewboard.asterisk.org/r/3765/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140718/39b4d008/attachment.html>