[asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

Scott Griepentrog reviewboard at asterisk.org
Thu Jul 17 18:16:51 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3796/#review12739
-----------------------------------------------------------

Ship it!


Ship It!

- Scott Griepentrog


On July 17, 2014, 2:29 p.m., Christopher Wolfe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3796/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 2:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24003
>     https://issues.asterisk.org/jira/browse/ASTERISK-24003
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> One test checks whether or not when two channels with accountcodes are stored in a mixing bridge, that the accountcode of one channel gets stored in the other's peeraccount, and that the LinkedId of the channel that entered the bridge first replaces the LinkedId of the bridge that entered last.  The other checks that the above conditions do NOT happen when two channels (one with an accountcode and one without) enter a holding bridge.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/bridges/tests.yaml 5249 
>   /asterisk/trunk/tests/rest_api/bridges/no_id_propagate/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/no_id_propagate/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/id_propagate/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/id_propagate/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3796/diff/
> 
> 
> Testing
> -------
> 
> Verified that expected values showed up in the Asterisk log files.
> Made conditions that verified that the last step occurred properly in order to progress the test.
> Compared the channels that entered the bridge with one that didn't.
> Originally had a python code approach, but then used strictly YAML and ari pluggable modules.
> 
> 
> Thanks,
> 
> Christopher Wolfe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/6ef63f8e/attachment.html>


More information about the asterisk-dev mailing list