[asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

[Corey Farrell]

> On July 17, 2014, 5:38 p.m., rmudgett wrote:
> > /team/group/media_formats-reviewed-trunk/main/format_compatibility.c, line 176
> > <https://reviewboard.asterisk.org/r/3822/diff/3/?file=64775#file64775line176>
> >
> >     I'm not sure this should be moved from the core since the conversion the other way is used by other modules.

Moving it back into the core if needed is easier than moving it out of the core after it is part of a release.  I can move it back now if you'd like, I took it out of the core on the assumption that we want to discourage use of these functions where possible.

If I don't hear back from you I'll move it back later tonight.


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3822/#review12732
-----------------------------------------------------------


On July 17, 2014, 4:06 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3822/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 4:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Move all ast_codec_pref functions to channels/iax2/codec_pref.c.
> * Move ast_format_compatibility_cap2bitfield, ast_format_compatibility_bitfield2cap and ast_format_compatibility_bitfield2format to channels/iax2/format_compatibility.c
> * Change prefix of all moved functions from ast_ to iax2_.
> * Fix comment in include/asterisk/config_options.h
> 
> ast_format_compatibility_format2bitfield and ast_format_compatibility_codec2bitfield are the only functions that remain in main/format_compatibility.c as they are used by other modules.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/main/format_compatibility.c 418850 
>   /team/group/media_formats-reviewed-trunk/include/asterisk/format_compatibility.h 418850 
>   /team/group/media_formats-reviewed-trunk/include/asterisk/config_options.h 418850 
>   /team/group/media_formats-reviewed-trunk/channels/iax2/parser.c 418850 
>   /team/group/media_formats-reviewed-trunk/channels/iax2/include/format_compatibility.h PRE-CREATION 
>   /team/group/media_formats-reviewed-trunk/channels/iax2/include/codec_pref.h PRE-CREATION 
>   /team/group/media_formats-reviewed-trunk/channels/iax2/format_compatibility.c PRE-CREATION 
>   /team/group/media_formats-reviewed-trunk/channels/iax2/codec_pref.c PRE-CREATION 
>   /team/group/media_formats-reviewed-trunk/channels/chan_iax2.c 418850 
> 
> Diff: https://reviewboard.asterisk.org/r/3822/diff/
> 
> 
> Testing
> -------
> 
> Compile only.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/c65fd526/attachment-0001.html>