[asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow
Matt Jordan
reviewboard at asterisk.org
Thu Jul 17 17:01:22 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3823/#review12736
-----------------------------------------------------------
trunk/configs/stasis.conf.sample
<https://reviewboard.asterisk.org/r/3823/#comment23050>
This should list out all of the stasis messages. A quick grep gets most of them:
grep --include=*.c -r STASIS_MESSAGE_TYPE_DEFN .
trunk/main/stasis.c
<https://reviewboard.asterisk.org/r/3823/#comment23051>
Since this option could be brutal, I'd add a NOTICE message to this that is emitted when a message type attempts to get created but gets rejected due to an explicit decline.
- Matt Jordan
On July 17, 2014, 7:49 a.m., opticron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3823/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 7:49 a.m.)
>
>
> Review request for Asterisk Developers and Corey Farrell.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This introduces stasis.conf and a mechanism to prevent certain message types from being published.
>
>
> Diffs
> -----
>
> trunk/tests/test_stasis_channels.c 418715
> trunk/tests/test_stasis.c 418715
> trunk/main/stasis_message.c 418715
> trunk/main/stasis_cache.c 418715
> trunk/main/stasis.c 418715
> trunk/include/asterisk/stasis.h 418715
> trunk/configs/stasis.conf.sample PRE-CREATION
>
> Diff: https://reviewboard.asterisk.org/r/3823/diff/
>
>
> Testing
> -------
>
> Tested by causing the stasis unittests to fail with the following stasis.conf configuration:
> [declined_message_types]
> decline=TestMessage
>
>
> Thanks,
>
> opticron
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/bab5bf62/attachment-0001.html>
More information about the asterisk-dev
mailing list