[asterisk-dev] [Code Review] 3809: features config: prevent assert on no featuregroups or applicationmap

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3809/#review12726
-----------------------------------------------------------

Ship it!


Minor nit about why the asserts are there.


/team/group/media_formats-reviewed-trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/3809/#comment23025>

    Add comment:
    We're dealing with the global config which must have the featuregroups and applicationmap containers.



/team/group/media_formats-reviewed-trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/3809/#comment23026>

    Same comment here.


- rmudgett


On July 17, 2014, 2:16 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3809/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 2:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> During testing, encountered an assert due to a null featuregroup passed to ao2_find().  This patch adds null checks around cfg->featuregroups and cfg->applicationmap, since they are not duplicated or initialized when features are copied.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed-trunk/main/features_config.c 418785 
> 
> Diff: https://reviewboard.asterisk.org/r/3809/diff/
> 
> 
> Testing
> -------
> 
> Repeated previously asserting test sequence with success.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/f184ac2d/attachment.html>