[asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3731/#review12716
-----------------------------------------------------------



team/rmudgett/stasis_linkedids/res/res_stasis.c
<https://reviewboard.asterisk.org/r/3731/#comment23004>

    This is the new ao2_replace().



team/rmudgett/stasis_linkedids/res/res_stasis.c
<https://reviewboard.asterisk.org/r/3731/#comment23005>

    The RAII_VAR is using chan before the assert checks if chan is NULL.



team/rmudgett/stasis_linkedids/res/stasis/app.h
<https://reviewboard.asterisk.org/r/3731/#comment23006>

    App must be ast_freed.



team/rmudgett/stasis_linkedids/res/stasis/app.c
<https://reviewboard.asterisk.org/r/3731/#comment23007>

    No NULL failure checks?


- rmudgett


On July 10, 2014, 8:35 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3731/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 8:35 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23941
>     https://issues.asterisk.org/jira/browse/ASTERISK-23941
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This intercepts channels attempting to enter stasis-controlled bridges that are not themselves controlled by stasis and routes them through Stasis() to be controlled by the Stasis application that controls the channels they are replacing.
> 
> 
> Diffs
> -----
> 
>   team/rmudgett/stasis_linkedids/rest-api/api-docs/events.json 418321 
>   team/rmudgett/stasis_linkedids/res/stasis/stasis_bridge.c 418321 
>   team/rmudgett/stasis_linkedids/res/stasis/control.c 418321 
>   team/rmudgett/stasis_linkedids/res/stasis/control.h 418321 
>   team/rmudgett/stasis_linkedids/res/stasis/app.c 418321 
>   team/rmudgett/stasis_linkedids/res/stasis/app.h 418321 
>   team/rmudgett/stasis_linkedids/res/res_stasis.c 418321 
>   team/rmudgett/stasis_linkedids/res/ari/ari_model_validators.c 418321 
>   team/rmudgett/stasis_linkedids/res/ari/ari_model_validators.h 418321 
> 
> Diff: https://reviewboard.asterisk.org/r/3731/diff/
> 
> 
> Testing
> -------
> 
> Tested against the updated ARI attended transfer test in https://reviewboard.asterisk.org/r/3732/
> 
> 
> File Attachments
> ----------------
> 
> Collation of thiis patch and dependency patches.
>   https://reviewboard.asterisk.org/media/uploaded/files/2014/07/10/3331f67f-8c7d-486f-bdcf-bf9a01aa288d__ari_atxfer.diff
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/b0649b5b/attachment.html>