[asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3796/#review12711
-----------------------------------------------------------


My comments can be applied to both tests, and multiple instances within a test of the same issue.


/asterisk/trunk/tests/rest_api/bridges/id_propagate/test-config.yaml
<https://reviewboard.asterisk.org/r/3796/#comment22997>

    Consistency:  Either match using regular expression or don't.  Match strings are always regular expressions, but it's not necessary to use alice$ unless you're concerned that an alice;2 could slip in unnoticed.  Pick one method and make that consistent for channel id matches:
    
    1) 'alice' - string contains alice, which is okay because alice and bob can't be confused
    2) 'alice$' - just to be sure alice;2 doesn't match since you are using local channels (even though alice;2 shouldn't be in stasis)
    3) '^alice$' - maximum paranoia mode to ensure string is exactly 'alice'.
    



/asterisk/trunk/tests/rest_api/bridges/id_propagate/test-config.yaml
<https://reviewboard.asterisk.org/r/3796/#comment22993>

    Move deleting alice to the last step as that triggers the end of the test.



/asterisk/trunk/tests/rest_api/bridges/id_propagate/test-config.yaml
<https://reviewboard.asterisk.org/r/3796/#comment22998>

    Since you're matching a single condition, there's no need to have the Channel name in both the conditions and the requirements.  You can match on the ;1 channel and drop the same channel from requirements match.


- Scott Griepentrog


On July 15, 2014, 2:28 p.m., Christopher Wolfe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3796/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 2:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24003
>     https://issues.asterisk.org/jira/browse/ASTERISK-24003
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> One test checks whether or not when two channels with accountcodes are stored in a mixing bridge, that the accountcode of one channel gets stored in the other's peeraccount, and that the LinkedId of the channel that entered the bridge first replaces the LinkedId of the bridge that entered last.  The other checks that the above conditions do NOT happen when two channels (one with an accountcode and one without) enter a holding bridge.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/bridges/tests.yaml 5242 
>   /asterisk/trunk/tests/rest_api/bridges/no_id_propagate/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/no_id_propagate/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/id_propagate/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/id_propagate/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3796/diff/
> 
> 
> Testing
> -------
> 
> Verified that expected values showed up in the Asterisk log files.
> Made conditions that verified that the last step occurred properly in order to progress the test.
> Compared the channels that entered the bridge with one that didn't.
> Originally had a python code approach, but then used strictly YAML and ari pluggable modules.
> 
> 
> Thanks,
> 
> Christopher Wolfe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/51774cb7/attachment.html>