[asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

[Corey Farrell]

> On July 16, 2014, 9:19 p.m., rmudgett wrote:
> > /trunk/res/res_smdi.c, line 1207
> > <https://reviewboard.asterisk.org/r/3758/diff/2/?file=64626#file64626line1207>
> >
> >     Yuck a shadowed variable.

Technically no the other 'iface' variable was in a different sub-scope (to allow use with RAII_VAR).  I've renamed this variable to mailbox_iface and moved the declaration to the top of the function.


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12704
-----------------------------------------------------------


On July 16, 2014, 9:29 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 9:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only remaining users are netsock.c (deprecated) and chan_sip (to be updated in a separate review).
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_smdi.c 418788 
>   /trunk/include/asterisk/smdi.h 418788 
>   /trunk/channels/sig_analog.c 418788 
>   /trunk/channels/chan_motif.c 418788 
>   /trunk/channels/chan_dahdi.c 418788 
>   /trunk/apps/app_voicemail.c 418788 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> -------
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/358e78e0/attachment.html>