[asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3819/#review12701
-----------------------------------------------------------



/trunk/main/bridge_channel.c
<https://reviewboard.asterisk.org/r/3819/#comment22978>

    You don't need to assign to NULL here since you are assigning a value in the next statement.



/trunk/main/bridge_channel.c
<https://reviewboard.asterisk.org/r/3819/#comment22979>

    I think you want strlen(app_args) + 1 instead of sizeof(app_args) which returns the size of a pointer.  I'm surprised this didn't crash from stack corruption.
    
    Look at using ast_str_substitute_variables() instead so you don't need to create a worst case fixed sized buffer for any substituted variables.


- rmudgett


On July 16, 2014, 6:53 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3819/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 6:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22608
>     https://issues.asterisk.org/jira/browse/ASTERISK-22608
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Say you wanted to include variables in an application map and have those variables substituted and passed along to the application being executed; currently this does not happen.
> This patch adds this new feature.
> 
> This simple patch was originally written for 1.4 but I have been maintaining it all the way up to version 11.  It is time to see if anyone else sees any value in this and get it committed.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/bridge_channel.c 416990 
> 
> Diff: https://reviewboard.asterisk.org/r/3819/diff/
> 
> 
> Testing
> -------
> 
> This has been in production since 1.4 and updated for trunk.  The trunk version of the patch was tested on dev machine.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140717/2d3f25ed/attachment.html>