[asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

[rmudgett]

> On July 13, 2014, 1:59 p.m., opticron wrote:
> > /trunk/res/res_smdi.c, line 394
> > <https://reviewboard.asterisk.org/r/3758/diff/1/?file=62870#file62870line394>
> >
> >     This can be accomplished with:
> >     ao2_callback(iface->mwi_q, OBJ_UNLINK | OBJ_NODATA, NULL, NULL);
> 
> Corey Farrell wrote:
>     Seems like I shouldn't use OBJ_NODATA since I'm returning the object?

Correct.  Remove the OBJ_NODATA and you'll delete and get the first object out of the container.  Keep the OBJ_NODATA and you'll just delete the first object in the container.  A NULL compare function means use the match anything default compare function.

You are using the iterator in an unusual way here and other places.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3758/#review12606
-----------------------------------------------------------


On July 12, 2014, 6:38 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3758/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 6:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This code converts res_smdi to use astobj2.
> 
> * Remove functions: ast_smdi_interface_unref, ast_smdi_md_message_putback, ast_smdi_mwi_message_putback, ast_smdi_md_message destructor, ast_smdi_mwi_message destructor.
> 
> The putback methods were unused and difficult to reimplement using ao2_containers.
> 
> Includes for astobj.h are removed everywhere it's possible.  The only remaining users are netsock.c (deprecated) and chan_sip (to be updated in a separate review).
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_smdi.c 418436 
>   /trunk/include/asterisk/smdi.h 418436 
>   /trunk/channels/sig_analog.c 418436 
>   /trunk/channels/dahdi/bridge_native_dahdi.c 418436 
>   /trunk/channels/chan_motif.c 418436 
>   /trunk/channels/chan_dahdi.c 418436 
>   /trunk/apps/app_voicemail.c 418436 
> 
> Diff: https://reviewboard.asterisk.org/r/3758/diff/
> 
> 
> Testing
> -------
> 
> Compile only (I do not have SMDI hardware).
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140716/10a811bd/attachment.html>