[asterisk-dev] [Code Review] 3808: media formats: Ensure MoH state is cleaned up properly

Joshua Colp reviewboard at asterisk.org
Wed Jul 16 12:11:31 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3808/#review12688
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On July 16, 2014, 5:05 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3808/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 5:05 p.m.)
> 
> 
> Review request for Asterisk Developers, Joshua Colp and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When MoH was converted to use refcounted formats, one of the two formats that a MoH state holds was not cleaned up properly. moh_files_release now handles both format references properly.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed-trunk/res/res_musiconhold.c 418779 
> 
> Diff: https://reviewboard.asterisk.org/r/3808/diff/
> 
> 
> Testing
> -------
> 
> Verified that the reference leak was fixed.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140716/9e3838e3/attachment.html>


More information about the asterisk-dev mailing list