[asterisk-dev] [Code Review] 3805: media formats: Ensure that chan_sip unloads cleanly

Joshua Colp reviewboard at asterisk.org
Wed Jul 16 10:47:35 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3805/#review12685
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On July 16, 2014, 2:57 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3805/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 2:57 p.m.)
> 
> 
> Review request for Asterisk Developers, Corey Farrell, Joshua Colp, and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This tweaks chan_sip to clean up after itself properly. Its unload_module() call is now also used as cleanup in case of module load declination or failure.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed-trunk/channels/chan_sip.c 418726 
> 
> Diff: https://reviewboard.asterisk.org/r/3805/diff/
> 
> 
> Testing
> -------
> 
> Verified that chan_sip cleaned itself up properly when failing or declining to load.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140716/55247693/attachment.html>


More information about the asterisk-dev mailing list