[asterisk-dev] [Code Review] 3804: sample configs: Move sample configs into a subfolder of configs to allow for additional sets of configuration files in the future

Joshua Colp reviewboard at asterisk.org
Wed Jul 16 09:44:53 CDT 2014 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3804/#review12684
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On July 16, 2014, 2:39 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3804/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 2:39 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch (despite looking rather large) is actually rather small: it simply moves all .conf.sample files in configs to configs/samples, and updates the Makefile's "make samples" target to copy from configs/samples.
> 
> Note: for whatever reason, Review Board is failing to pick up the fact that the content was moved and not just deleted. The files were moved to the configs/samples folder using svn mv, so revision history should not be lost by this change.
> 
> The reason for this change is to allow for additional configuration file sets to be added to Asterisk in the future. Conceivably, we could have a 'make hello-world' that creates a configuration with only a single PJSIP endpoint and a simple dialplan that plays 'demo-congrats', or a 'make small-business-pbx' (or the like). This could potentially make it easier for people to lab up and get Asterisk configured for simple exercises, as opposed to having to wade through the rather large sample configuration files (which exist more as documentation and less as a recommended way of having Asterisk configured).
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/xmpp.conf.sample 418777 
>   /trunk/configs/vpb.conf.sample 418777 
>   /trunk/configs/voicemail.conf.sample 418777 
>   /trunk/configs/users.conf.sample 418777 
>   /trunk/configs/unistim.conf.sample 418777 
>   /trunk/configs/udptl.conf.sample 418777 
>   /trunk/configs/test_sorcery.conf.sample 418777 
>   /trunk/configs/telcordia-1.adsi 418777 
>   /trunk/configs/statsd.conf.sample 418777 
>   /trunk/configs/ss7.timers.sample 418777 
>   /trunk/configs/sorcery.conf.sample 418777 
>   /trunk/configs/smdi.conf.sample 418777 
>   /trunk/configs/sla.conf.sample 418777 
>   /trunk/configs/skinny.conf.sample 418777 
>   /trunk/configs/sip_notify.conf.sample 418777 
>   /trunk/configs/sip.conf.sample 418777 
>   /trunk/configs/say.conf.sample 418777 
>   /trunk/configs/rtp.conf.sample 418777 
>   /trunk/configs/res_stun_monitor.conf.sample 418777 
>   /trunk/configs/res_snmp.conf.sample 418777 
>   /trunk/configs/res_pktccops.conf.sample 418777 
>   /trunk/configs/res_pgsql.conf.sample PRE-CREATION 
>   /trunk/configs/res_pgsql.conf.sample 418777 
>   /trunk/configs/res_parking.conf.sample 418777 
>   /trunk/configs/res_odbc.conf.sample 418777 
>   /trunk/configs/res_ldap.conf.sample 418777 
>   /trunk/configs/res_fax.conf.sample 418777 
>   /trunk/configs/res_curl.conf.sample 418777 
>   /trunk/configs/res_corosync.conf.sample 418777 
>   /trunk/configs/res_config_sqlite3.conf.sample 418777 
>   /trunk/configs/res_config_sqlite.conf.sample 418777 
>   /trunk/configs/res_config_mysql.conf.sample 418777 
>   /trunk/configs/queues.conf.sample 418777 
>   /trunk/configs/queuerules.conf.sample 418777 
>   /trunk/configs/pjsip_notify.conf.sample 418777 
>   /trunk/configs/pjsip.conf.sample 418777 
>   /trunk/configs/phoneprov.conf.sample 418777 
>   /trunk/configs/phone.conf.sample 418777 
>   /trunk/configs/oss.conf.sample 418777 
>   /trunk/configs/osp.conf.sample 418777 
>   /trunk/configs/ooh323.conf.sample 418777 
>   /trunk/configs/muted.conf.sample 418777 
>   /trunk/configs/musiconhold.conf.sample 418777 
>   /trunk/configs/motif.conf.sample 418777 
>   /trunk/configs/modules.conf.sample 418777 
>   /trunk/configs/misdn.conf.sample 418777 
>   /trunk/configs/minivm.conf.sample 418777 
>   /trunk/configs/mgcp.conf.sample 418777 
>   /trunk/configs/meetme.conf.sample 418777 
>   /trunk/configs/manager.conf.sample 418777 
>   /trunk/configs/logger.conf.sample 418777 
>   /trunk/configs/indications.conf.sample 418777 
>   /trunk/configs/iaxprov.conf.sample 418777 
>   /trunk/configs/iax.conf.sample 418777 
>   /trunk/configs/http.conf.sample 418777 
>   /trunk/configs/hep.conf.sample 418777 
>   /trunk/configs/func_odbc.conf.sample 418777 
>   /trunk/configs/followme.conf.sample 418777 
>   /trunk/configs/festival.conf.sample 418777 
>   /trunk/configs/features.conf.sample 418777 
>   /trunk/configs/extensions_minivm.conf.sample 418777 
>   /trunk/configs/extensions.lua.sample 418777 
>   /trunk/configs/extensions.conf.sample 418777 
>   /trunk/configs/extensions.ael.sample 418777 
>   /trunk/configs/extconfig.conf.sample 418777 
>   /trunk/configs/enum.conf.sample 418777 
>   /trunk/configs/dundi.conf.sample 418777 
>   /trunk/configs/dsp.conf.sample 418777 
>   /trunk/configs/dnsmgr.conf.sample 418777 
>   /trunk/configs/dbsep.conf.sample 418777 
>   /trunk/configs/console.conf.sample 418777 
>   /trunk/configs/config_test.conf.sample 418777 
>   /trunk/configs/confbridge.conf.sample 418777 
>   /trunk/configs/codecs.conf.sample 418777 
>   /trunk/configs/cli_permissions.conf.sample 418777 
>   /trunk/configs/cli_aliases.conf.sample 418777 
>   /trunk/configs/cli.conf.sample 418777 
>   /trunk/configs/chan_mobile.conf.sample 418777 
>   /trunk/configs/chan_dahdi.conf.sample 418777 
>   /trunk/configs/cel_tds.conf.sample 418777 
>   /trunk/configs/cel_sqlite3_custom.conf.sample 418777 
>   /trunk/configs/cel_pgsql.conf.sample PRE-CREATION 
>   /trunk/configs/cel_pgsql.conf.sample 418777 
>   /trunk/configs/cel_odbc.conf.sample 418777 
>   /trunk/configs/cel_custom.conf.sample 418777 
>   /trunk/configs/cel.conf.sample 418777 
>   /trunk/configs/cdr_tds.conf.sample 418777 
>   /trunk/configs/cdr_syslog.conf.sample 418777 
>   /trunk/configs/cdr_sqlite3_custom.conf.sample 418777 
>   /trunk/configs/cdr_pgsql.conf.sample PRE-CREATION 
>   /trunk/configs/cdr_pgsql.conf.sample 418777 
>   /trunk/configs/cdr_odbc.conf.sample 418777 
>   /trunk/configs/cdr_mysql.conf.sample 418777 
>   /trunk/configs/cdr_manager.conf.sample 418777 
>   /trunk/configs/cdr_custom.conf.sample 418777 
>   /trunk/configs/cdr_adaptive_odbc.conf.sample 418777 
>   /trunk/configs/cdr.conf.sample 418777 
>   /trunk/configs/ccss.conf.sample 418777 
>   /trunk/configs/calendar.conf.sample 418777 
>   /trunk/configs/asterisk.conf.sample 418777 
>   /trunk/configs/asterisk.adsi 418777 
>   /trunk/configs/ari.conf.sample 418777 
>   /trunk/configs/app_skel.conf.sample 418777 
>   /trunk/configs/app_mysql.conf.sample 418777 
>   /trunk/configs/amd.conf.sample 418777 
>   /trunk/configs/alsa.conf.sample 418777 
>   /trunk/configs/alarmreceiver.conf.sample 418777 
>   /trunk/configs/agents.conf.sample 418777 
>   /trunk/configs/adsi.conf.sample 418777 
>   /trunk/configs/acl.conf.sample 418777 
>   /trunk/Makefile 418777 
> 
> Diff: https://reviewboard.asterisk.org/r/3804/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140716/0ddbed8b/attachment-0001.html>

More information about the asterisk-dev mailing list