[asterisk-dev] [Code Review] 3724: chan_pjsip: Allow an endpoint to set an accountcode on channels via an endpoint configuration setting

[Matt Jordan]

> On July 9, 2014, 11 a.m., rmudgett wrote:
> > /branches/12/contrib/ast-db-manage/config/versions/1d50859ed02e_create_accountcode.py, line 17
> > <https://reviewboard.asterisk.org/r/3724/diff/1/?file=62478#file62478line17>
> >
> >     A size of twenty?  Seems potentially too small.
> >     
> >     Is there precedent for accountcode to be this small?
> 
> Matt Jordan wrote:
>     This matches the value of AST_MAX_ACCOUNT_CODE
> 
> Corey Farrell wrote:
>     Why not use AST_MAX_ACCOUNT_CODE instead of hard-coding 20?

AST_MAX_ACCOUNT_CODE is a C defined macro. This line is in a Python script :-)


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3724/#review12524
-----------------------------------------------------------


On July 15, 2014, 6:24 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3724/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 6:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24000
>     https://issues.asterisk.org/jira/browse/ASTERISK-24000
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Most channel drivers let you specify a default accountcode for channels associated with a particular endpoint/peer/thing. chan_pjsip/res_pjsip does not.
> 
> This patch adds a new setting to the endpoint object (accountcode!) that does that.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/pjsip_configuration.c 418714 
>   /branches/12/res/res_pjsip.c 418714 
>   /branches/12/include/asterisk/res_pjsip.h 418714 
>   /branches/12/contrib/ast-db-manage/config/versions/1d50859ed02e_create_accountcode.py PRE-CREATION 
>   /branches/12/configs/pjsip.conf.sample 418714 
>   /branches/12/channels/chan_pjsip.c 418714 
>   /branches/12/CHANGES 418714 
> 
> Diff: https://reviewboard.asterisk.org/r/3724/diff/
> 
> 
> Testing
> -------
> 
> See https://reviewboard.asterisk.org/r/3725
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140715/77b4bde1/attachment.html>