[asterisk-dev] [Code Review] 3802: Add module support level to module info; print module support level in CLI "module show" command.
Corey Farrell
reviewboard at asterisk.org
Tue Jul 15 17:53:16 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3802/#review12674
-----------------------------------------------------------
/trunk/include/asterisk/module.h
<https://reviewboard.asterisk.org/r/3802/#comment22945>
AST_MODULE_SUPPORT_UNKNOWN should be 0 that way it's the default if someone doesn't update the source to specify a value.
/trunk/main/loader.c
<https://reviewboard.asterisk.org/r/3802/#comment22946>
This likely needs to be reordered as well.
- Corey Farrell
On July 15, 2014, 6:35 p.m., Mark Michelson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3802/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 6:35 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-23919
> https://issues.asterisk.org/jira/browse/ASTERISK-23919
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This updates the ast_module_info structure to include the support level of the module. I wrote a python script to convert all existing modules to include their support levels.
>
> In addition, I have updated the CLI command "module show" to have an extra column that states the support level of each module.
>
> The largest changes in this request are on page 6 of the review in include/asterisk/module.h, main/cli.c, and main/loader.c.
>
>
> Diffs
> -----
>
> /trunk/res/snmp/agent.c 418633
> /trunk/res/res_xmpp.c 418633
> /trunk/res/res_timing_timerfd.c 418633
> /trunk/res/res_timing_pthread.c 418633
> /trunk/res/res_timing_kqueue.c 418633
> /trunk/res/res_timing_dahdi.c 418633
> /trunk/res/res_stun_monitor.c 418633
> /trunk/res/res_statsd.c 418633
> /trunk/res/res_stasis_test.c 418633
> /trunk/res/res_stasis_snoop.c 418633
> /trunk/res/res_stasis_recording.c 418633
> /trunk/res/res_stasis_playback.c 418633
> /trunk/res/res_stasis_mailbox.c 418633
> /trunk/res/res_stasis_device_state.c 418633
> /trunk/res/res_stasis_answer.c 418633
> /trunk/res/res_stasis.c 418633
> /trunk/res/res_srtp.c 418633
> /trunk/res/res_speech.c 418633
> /trunk/res/res_sorcery_realtime.c 418633
> /trunk/res/res_sorcery_memory.c 418633
> /trunk/res/res_sorcery_config.c 418633
> /trunk/res/res_sorcery_astdb.c 418633
> /trunk/res/res_snmp.c 418633
> /trunk/res/res_smdi.c 418633
> /trunk/res/res_rtp_multicast.c 418633
> /trunk/res/res_rtp_asterisk.c 418633
> /trunk/res/res_pktccops.c 418633
> /trunk/res/res_pjsip_xpidf_body_generator.c 418633
> /trunk/res/res_pjsip_transport_websocket.c 418633
> /trunk/res/res_pjsip_t38.c 418633
> /trunk/res/res_pjsip_session.c 418633
> /trunk/res/res_pjsip_send_to_voicemail.c 418633
> /trunk/res/res_pjsip_sdp_rtp.c 418633
> /trunk/res/res_pjsip_rfc3326.c 418633
> /trunk/res/res_pjsip_registrar_expire.c 418633
> /trunk/res/res_pjsip_registrar.c 418633
> /trunk/res/res_pjsip_refer.c 418633
> /trunk/res/res_pjsip_pubsub.c 418633
> /trunk/res/res_pjsip_pidf_eyebeam_body_supplement.c 418633
> /trunk/res/res_pjsip_pidf_digium_body_supplement.c 418633
> /trunk/res/res_pjsip_pidf_body_generator.c 418633
> /trunk/res/res_pjsip_path.c 418633
> /trunk/res/res_pjsip_outbound_registration.c 418633
> /trunk/res/res_pjsip_outbound_authenticator_digest.c 418633
> /trunk/res/res_pjsip_one_touch_record_info.c 418633
> /trunk/res/res_pjsip_notify.c 418633
> /trunk/res/res_pjsip_nat.c 418633
> /trunk/res/res_pjsip_mwi_body_generator.c 418633
> /trunk/res/res_pjsip_mwi.c 418633
> /trunk/res/res_pjsip_multihomed.c 418633
> /trunk/res/res_pjsip_messaging.c 418633
> /trunk/res/res_pjsip_logger.c 418633
> /trunk/res/res_pjsip_log_forwarder.c 418633
> /trunk/res/res_pjsip_header_funcs.c 418633
> /trunk/res/res_pjsip_exten_state.c 418633
> /trunk/res/res_pjsip_endpoint_identifier_user.c 418633
> /trunk/res/res_pjsip_endpoint_identifier_ip.c 418633
> /trunk/res/res_pjsip_endpoint_identifier_anonymous.c 418633
> /trunk/res/res_pjsip_dtmf_info.c 418633
> /trunk/res/res_pjsip_diversion.c 418633
> /trunk/res/res_pjsip_dialog_info_body_generator.c 418633
> /trunk/res/res_pjsip_caller_id.c 418633
> /trunk/res/res_pjsip_authenticator_digest.c 418633
> /trunk/res/res_pjsip_acl.c 418633
> /trunk/res/res_pjsip.c 418633
> /trunk/res/res_phoneprov.c 418633
> /trunk/res/res_parking.c 418633
> /trunk/res/res_odbc.c 418633
> /trunk/res/res_mwi_external_ami.c 418633
> /trunk/res/res_mwi_external.c 418633
> /trunk/res/res_musiconhold.c 418633
> /trunk/res/res_monitor.c 418633
> /trunk/res/res_manager_presencestate.c 418633
> /trunk/res/res_manager_devicestate.c 418633
> /trunk/res/res_http_websocket.c 418633
> /trunk/res/res_http_post.c 418633
> /trunk/res/res_hep_pjsip.c 418633
> /trunk/res/res_hep.c 418633
> /trunk/res/res_format_attr_silk.c 418633
> /trunk/res/res_format_attr_opus.c 418633
> /trunk/res/res_format_attr_h264.c 418633
> /trunk/res/res_format_attr_h263.c 418633
> /trunk/res/res_format_attr_celt.c 418633
> /trunk/res/res_fax_spandsp.c 418633
> /trunk/res/res_fax.c 418633
> /trunk/res/res_curl.c 418633
> /trunk/res/res_crypto.c 418633
> /trunk/res/res_corosync.c 418633
> /trunk/res/res_config_sqlite3.c 418633
> /trunk/res/res_config_sqlite.c 418633
> /trunk/res/res_config_pgsql.c 418633
> /trunk/res/res_config_odbc.c 418633
> /trunk/res/res_config_ldap.c 418633
> /trunk/res/res_config_curl.c 418633
> /trunk/res/res_clialiases.c 418633
> /trunk/res/res_chan_stats.c 418633
> /trunk/res/res_calendar_icalendar.c 418633
> /trunk/res/res_calendar_exchange.c 418633
> /trunk/res/res_calendar_ews.c 418633
> /trunk/res/res_calendar_caldav.c 418633
> /trunk/res/res_calendar.c 418633
> /trunk/res/res_ari_sounds.c 418633
> /trunk/res/res_ari_recordings.c 418633
> /trunk/res/res_ari_playbacks.c 418633
> /trunk/res/res_ari_model.c 418633
> /trunk/res/res_ari_mailboxes.c 418633
> /trunk/res/res_ari_events.c 418633
> /trunk/res/res_ari_endpoints.c 418633
> /trunk/res/res_ari_device_states.c 418633
> /trunk/res/res_ari_channels.c 418633
> /trunk/res/res_ari_bridges.c 418633
> /trunk/res/res_ari_asterisk.c 418633
> /trunk/res/res_ari_applications.c 418633
> /trunk/res/res_ari.c 418633
> /trunk/res/res_agi.c 418633
> /trunk/res/res_ael_share.c 418633
> /trunk/res/res_adsi.c 418633
> /trunk/pbx/pbx_realtime.c 418633
> /trunk/include/asterisk/module.h 418633
> /trunk/funcs/func_presencestate.c 418633
> /trunk/funcs/func_pitchshift.c 418633
> /trunk/funcs/func_periodic_hook.c 418633
> /trunk/funcs/func_odbc.c 418633
> /trunk/funcs/func_frame_trace.c 418633
> /trunk/funcs/func_dialplan.c 418633
> /trunk/funcs/func_devstate.c 418633
> /trunk/funcs/func_curl.c 418633
> /trunk/funcs/func_aes.c 418633
> /trunk/formats/format_wav_gsm.c 418633
> /trunk/formats/format_wav.c 418633
> /trunk/formats/format_vox.c 418633
> /trunk/formats/format_sln.c 418633
> /trunk/formats/format_siren7.c 418633
> /trunk/formats/format_siren14.c 418633
> /trunk/formats/format_pcm.c 418633
> /trunk/formats/format_ogg_vorbis.c 418633
> /trunk/formats/format_jpeg.c 418633
> /trunk/formats/format_ilbc.c 418633
> /trunk/formats/format_h264.c 418633
> /trunk/formats/format_h263.c 418633
> /trunk/formats/format_gsm.c 418633
> /trunk/formats/format_g729.c 418633
> /trunk/formats/format_g726.c 418633
> /trunk/formats/format_g723.c 418633
> /trunk/formats/format_g719.c 418633
> /trunk/codecs/codec_ulaw.c 418633
> /trunk/codecs/codec_speex.c 418633
> /trunk/codecs/codec_lpc10.c 418633
> /trunk/codecs/codec_gsm.c 418633
> /trunk/codecs/codec_g726.c 418633
> /trunk/codecs/codec_g722.c 418633
> /trunk/codecs/codec_dahdi.c 418633
> /trunk/codecs/codec_alaw.c 418633
> /trunk/codecs/codec_adpcm.c 418633
> /trunk/channels/chan_unistim.c 418633
> /trunk/channels/chan_skinny.c 418633
> /trunk/channels/chan_sip.c 418633
> /trunk/channels/chan_pjsip.c 418633
> /trunk/channels/chan_phone.c 418633
> /trunk/channels/chan_oss.c 418633
> /trunk/channels/chan_nbs.c 418633
> /trunk/channels/chan_multicast_rtp.c 418633
> /trunk/channels/chan_motif.c 418633
> /trunk/channels/chan_misdn.c 418633
> /trunk/channels/chan_mgcp.c 418633
> /trunk/channels/chan_iax2.c 418633
> /trunk/channels/chan_dahdi.c 418633
> /trunk/channels/chan_console.c 418633
> /trunk/channels/chan_bridge_media.c 418633
> /trunk/channels/chan_alsa.c 418633
> /trunk/cel/cel_tds.c 418633
> /trunk/cel/cel_sqlite3_custom.c 418633
> /trunk/cel/cel_radius.c 418633
> /trunk/cel/cel_pgsql.c 418633
> /trunk/cel/cel_odbc.c 418633
> /trunk/cel/cel_manager.c 418633
> /trunk/cel/cel_custom.c 418633
> /trunk/cdr/cdr_tds.c 418633
> /trunk/cdr/cdr_syslog.c 418633
> /trunk/cdr/cdr_sqlite3_custom.c 418633
> /trunk/cdr/cdr_sqlite.c 418633
> /trunk/cdr/cdr_radius.c 418633
> /trunk/cdr/cdr_pgsql.c 418633
> /trunk/cdr/cdr_odbc.c 418633
> /trunk/cdr/cdr_manager.c 418633
> /trunk/cdr/cdr_custom.c 418633
> /trunk/cdr/cdr_csv.c 418633
> /trunk/cdr/cdr_adaptive_odbc.c 418633
> /trunk/apps/app_zapateller.c 418633
> /trunk/apps/app_waitforsilence.c 418633
> /trunk/apps/app_waitforring.c 418633
> /trunk/apps/app_voicemail.c 418633
> /trunk/pbx/pbx_lua.c 418633
> /trunk/pbx/pbx_dundi.c 418633
> /trunk/pbx/pbx_config.c 418633
> /trunk/pbx/pbx_ael.c 418633
> /trunk/main/loader.c 418633
> /trunk/main/cli.c 418633
> /trunk/apps/app_url.c 418633
> /trunk/apps/app_test.c 418633
> /trunk/apps/app_talkdetect.c 418633
> /trunk/apps/app_stasis.c 418633
> /trunk/apps/app_stack.c 418633
> /trunk/apps/app_speech_utils.c 418633
> /trunk/apps/app_sms.c 418633
> /trunk/apps/app_skel.c 418633
> /trunk/apps/app_setcallerid.c 418633
> /trunk/apps/app_saycounted.c 418633
> /trunk/apps/app_queue.c 418633
> /trunk/apps/app_playback.c 418633
> /trunk/apps/app_osplookup.c 418633
> /trunk/apps/app_nbscat.c 418633
> /trunk/apps/app_mp3.c 418633
> /trunk/apps/app_morsecode.c 418633
> /trunk/apps/app_minivm.c 418633
> /trunk/apps/app_meetme.c 418633
> /trunk/apps/app_jack.c 418633
> /trunk/apps/app_ivrdemo.c 418633
> /trunk/apps/app_image.c 418633
> /trunk/apps/app_ices.c 418633
> /trunk/apps/app_getcpeid.c 418633
> /trunk/apps/app_followme.c 418633
> /trunk/apps/app_festival.c 418633
> /trunk/apps/app_fax.c 418633
> /trunk/apps/app_externalivr.c 418633
> /trunk/apps/app_dictate.c 418633
> /trunk/apps/app_dahdiras.c 418633
> /trunk/apps/app_confbridge.c 418633
> /trunk/apps/app_chanisavail.c 418633
> /trunk/apps/app_celgenuserevent.c 418633
> /trunk/apps/app_amd.c 418633
> /trunk/apps/app_alarmreceiver.c 418633
> /trunk/apps/app_agent_pool.c 418633
> /trunk/apps/app_adsiprog.c 418633
> /trunk/addons/res_config_mysql.c 418633
> /trunk/addons/format_mp3.c 418633
> /trunk/addons/chan_ooh323.c 418633
> /trunk/addons/chan_mobile.c 418633
> /trunk/addons/cdr_mysql.c 418633
> /trunk/addons/app_mysql.c 418633
>
> Diff: https://reviewboard.asterisk.org/r/3802/diff/
>
>
> Testing
> -------
>
> Ran CLI command "module show" . Lines look like this:
>
> *CLI> module show
> Module Description Use Count Status Support Level
> app_adsiprog.so Asterisk ADSI Programming Application 0 Running extended
> app_agent_pool.so Call center agent pool applications 0 Not Running core
> app_alarmreceiver.so Alarm Receiver for Asterisk 0 Running extended
> app_amd.so Answering Machine Detection Application 0 Running extended
> app_authenticate.so Authentication Application 0 Running core
> app_bridgewait.so Place the channel into a holding bridge 0 Running core
> app_cdr.so Tell Asterisk to not maintain a CDR for 0 Running core
> app_celgenuserevent.so Generate an User-Defined CEL event 0 Running core
> app_chanisavail.so Check channel availability 0 Running extended
> app_channelredirect.so Redirects a given channel to a dialplan 0 Running core
> app_chanspy.so Listen to the audio of an active channel 0 Running core
> app_confbridge.so Conference Bridge Application 0 Running core
> app_controlplayback.so Control Playback Application 0 Running core
> app_dahdiras.so DAHDI ISDN Remote Access Server 0 Running extended
> app_db.so Database Access Functions 0 Running core
> ...
>
>
> Thanks,
>
> Mark Michelson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140715/9bc37c02/attachment-0001.html>
More information about the asterisk-dev
mailing list